Fixes #33765 - Use a system user without a login shell #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user pulp doesn't need to login so it's set to /sbin/nologin.
It should also be a system user. This doesn't affect exsting
installations, but it ensures fresh installations are clean. From
useradd's man page:
System users will be created with no aging information in
/etc/shadow, and their numeric identifiers are chosen in the
SYS_UID_MIN-SYS_UID_MAX range, defined in /etc/login.defs, instead
of UID_MIN-UID_MAX (and their GID counterparts for the creation of
groups).
This typically means newly created pulp users will end up with a UID <
1000 while with the current code it's > 1000.
ekohl
force-pushed
the
33765-set-nologin-shell
branch
from
88ca6fa to
5a7991a
Compare
|
Can you expand on why we want a system user? I feel like sometimes I hear users who have policies around UID needing to be above 1000. |
|
System users are typically used for non-humans. pulp is also typically a system service: it doesn't log in and only needs to be there for proper file permissions and so services can run as that user. foreman and foreman-proxy are also system users. This just makes it consistent. |
ehelms
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user pulp doesn't need to login so it's set to /sbin/nologin.
It should also be a system user. This doesn't affect exsting installations, but it ensures fresh installations are clean. From useradd's man page:
This typically means newly created pulp users will end up with a UID < 1000 while with the current code it's > 1000.