-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #33766 - Support Pulpcore 3.15 #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hear 3.16 is being worked on as well, but 3.15 is built today and is SCL'ed. On EL8 it also uses modules for Python 3.8. Having this PR allows us to verify we actually work.
@@ -140,7 +140,7 @@ | |||
# Modification should be performed incrementally to determine the least value that prevents false positive worker timeouts. | |||
# | |||
# @param use_rq_tasking_system | |||
# Use the older RQ workers tasking system instead of the newer PostgreSQL tasking system introduced in Pulpcore 3.14. | |||
# Use the older RQ workers tasking system instead of the newer PostgreSQL tasking system introduced in Pulpcore 3.14. This is deprecated in 3.15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And will be removed in 3.16.
Looks like RQ is broken on EL7 with 3.15 but EL8 does pass. Perhaps some SCL issue. |
You could go either way that this broken rq depending on how we think about exposing the command line tool. The tests use So we either update packaging to make an SCL aware |
I'm leaning to the latter. We can even take the version into account here. |
this ensures the right SELinux context is set and also allows to use the SCL (if there is any)
The RQ issue is simple to fix: #240 |
Since python3-certguard 1.4.0-3 this is solved in packaging. That clears the path for Pulp 3.15.
This is now green. With the notes in README I would consider this a backwards compatible enhancement. |
No description provided.