Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #16: Drop postgresql globals #26

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Dec 6, 2019

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move it to the acceptance test:

let(:pp) { 'include pulpcore' }

@ehelms ehelms force-pushed the drop-globals branch 2 times, most recently from 76ca32d to ebc2d89 Compare December 6, 2019 21:39
@ehelms
Copy link
Member Author

ehelms commented Dec 6, 2019

How do you figure out why this is failing? The error messages don't seem to indicate.

spec/acceptance/basic_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think heredoc is easier to read, but since it's test code I don't mind merging it.

@wbclark
Copy link
Collaborator

wbclark commented Dec 9, 2019

When I check this out and apply it on a vagrant centos7 box, it is failing due to:

[1;31mError: Execution of '/bin/yum -d 0 -e 0 -y install python3-pulpcore' returned 1: Error: Nothing to do[0m

It seems the repository is not available:

[root@centos7 ~]# yum install python3-pulpcore
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile
 * base: mirror.linux.duke.edu
 * centos-sclo-rh: centos.vwtonline.net
 * epel: mirror.dst.ca
 * extras: packages.oit.ncsu.edu
 * updates: packages.oit.ncsu.edu
No package python3-pulpcore available.
Error: Nothing to do

EDIT: This issue is on my end. Updating my playbook to enable the proper repository should work.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the failure in the migration I think a let block with 2 strings means it only returns the last one (unlike Python which concats them). Please implement my heredoc suggestion to make it a single string.

@wbclark
Copy link
Collaborator

wbclark commented Dec 9, 2019

After updating my playbook to enable the pulpcore repository, my tests are failing at the same point as on Travis:

    [mNotice: /Stage[main]/Pulpcore::Database/Exec[django-admin migrate --noinput]/returns:   Applying auth.0011_update_proxy_permissions... OK[0m
    [mNotice: /Stage[main]/Pulpcore::Database/Exec[django-admin migrate --noinput]/returns:   Applying core.0001_initial...Traceback (most recent call last):[0m
    [mNotice: /Stage[main]/Pulpcore::Database/Exec[django-admin migrate --noinput]/returns:   File "/usr/lib/python3.6/site-packages/django/db/backends/utils.py", line 82, in _execute[0m
    [mNotice: /Stage[main]/Pulpcore::Database/Exec[django-admin migrate --noinput]/returns:     return self.cursor.execute(sql)[0m
    [mNotice: /Stage[main]/Pulpcore::Database/Exec[django-admin migrate --noinput]/returns: psycopg2.errors.UndefinedObject: type "jsonb" does not exist[0m

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you did nicely confirm we really need a postgres version newer than in EL7 base :)

@ehelms ehelms merged commit de3564f into theforeman:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants