-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #16: Drop postgresql globals #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move it to the acceptance test:
let(:pp) { 'include pulpcore' } |
76ca32d
to
ebc2d89
Compare
How do you figure out why this is failing? The error messages don't seem to indicate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think heredoc is easier to read, but since it's test code I don't mind merging it.
When I check this out and apply it on a vagrant centos7 box, it is failing due to:
It seems the repository is not available:
EDIT: This issue is on my end. Updating my playbook to enable the proper repository should work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the failure in the migration I think a let block with 2 strings means it only returns the last one (unlike Python which concats them). Please implement my heredoc suggestion to make it a single string.
After updating my playbook to enable the pulpcore repository, my tests are failing at the same point as on Travis:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you did nicely confirm we really need a postgres version newer than in EL7 base :)
No description provided.