Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36438 - configure API request limit to avoid memory leaks #289

Merged
merged 1 commit into from
May 25, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 25, 2023

No description provided.

@ekohl ekohl added the Enhancement New feature or request label May 25, 2023
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note about the tests, but otherwise 👍

spec/classes/pulpcore_spec.rb Outdated Show resolved Hide resolved
spec/classes/pulpcore_spec.rb Outdated Show resolved Hide resolved
@ekohl ekohl merged commit 5780e8a into theforeman:master May 25, 2023
@evgeni evgeni deleted the i36438 branch May 25, 2023 11:02
@@ -233,6 +239,8 @@
Integer[0] $api_service_worker_count = min(4, $facts['processors']['count']) + 1,
Integer[0] $content_service_worker_timeout = 90,
Integer[0] $api_service_worker_timeout = 90,
Integer[0] $api_service_worker_max_requests = 50,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgeni We discovered the "real" root cause now, so we can relax this number significantly. I would back it off to a much higher value, like say 1000 for the limit and 200 for the jitter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to info about the real root cause?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the discussion near the end on the BZ https://bugzilla.redhat.com/show_bug.cgi?id=2122872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants