Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuring HIDE_GUARDED_DISTRIBUTIONS setting #292

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jun 20, 2023

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the README we still support older versions. Do we care about those? They won't break, but I'm tempted to add a note to README that hide_guarded_distributions won't do anything.

@ekohl ekohl added the Enhancement New feature or request label Jun 20, 2023
@evgeni
Copy link
Member Author

evgeni commented Jun 20, 2023

We could add that to the help string or the readme, yes.

On the other hand, I doubt anyone would actually go try enabling this without reading pulpcore docs, that don't mention it on pre-3.22?

@ekohl ekohl force-pushed the hide_guarded_distributions branch from f7bbc06 to 6a8a0dc Compare June 20, 2023 12:22
@ekohl ekohl enabled auto-merge (rebase) June 20, 2023 12:28
@ekohl ekohl merged commit cce4b7d into master Jun 20, 2023
@ekohl ekohl deleted the hide_guarded_distributions branch June 20, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants