Remove Certguard and File installation as plugin #336
Conversation
Odilhao
force-pushed
the
pulp-3.49
branch
3 times, most recently
from
d94826b to
defdb38
Compare
| @@ -1,14 +1,14 @@ | |||
| # @summary Pulp Deb plugin | |||
| # @param use_pulp2_content_route | |||
There was a problem hiding this comment.
Should we also keep this @ekohl ?
There was a problem hiding this comment.
I'd imagine so. These are endpoints that Pulp 2 users can use continue using.
Odilhao
force-pushed
the
pulp-3.49
branch
3 times, most recently
from
febbcbb to
6838c6e
Compare
It was now merged into pulpcore
There was a problem hiding this comment.
I think you didn't really understand my comments, so taking a step back.
Previously we had a setting for each plugin. These are set here. These compatibility endpoints are not part of Pulp itself, but Katello chooses to keep them for now so users don't have to change URLs on clients. The reason we have booleans is that we can at some point start deprecating them, provide an option to turn them off, default to off and eventually drop them.
If you're dropping the file plugin because it's merged in core, we still want to provide that functionality. That means the parameter needs to move to core. We don't need to change the other plugins if we just move it to init.pp and scope it to just the isos endpoint.
Now we can consider a redesign where there is one global parameter in pulpcore (so init.pp) that plugins can respect, but I'm not sure that's needed.
Also note that once we merge this, we must also modify puppet-foreman_proxy_content.
And this should update README to describe the Pulpcore compatibility.
|
FWIW, we added |
It was now merged into pulpcore