Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to configure auth backends and classes #346

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add ability to configure auth backends and classes #346

merged 1 commit into from
Aug 9, 2024

Conversation

Scnaeg
Copy link
Contributor

@Scnaeg Scnaeg commented Jun 18, 2024

No description provided.

ekohl
ekohl reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some tests for this.

@ekohl ekohl added the Enhancement New feature or request label Jun 18, 2024
@Scnaeg
Copy link
Contributor Author

Scnaeg commented Jun 24, 2024

It would be nice to have some tests for this.

I've added some tests. Unfortunately bundler has conflicting requirements on the RHEL 8 system I have available so I couldn't actually run the tests and verify the tests.

@Scnaeg Scnaeg force-pushed the configure_auth_backend_classes branch from b78dd3c to 5539ac7 Compare June 25, 2024 08:41
ekohl
ekohl reviewed Aug 8, 2024
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
spec/acceptance/settings_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/settings_spec.rb Outdated Show resolved Hide resolved
@Scnaeg Scnaeg force-pushed the configure_auth_backend_classes branch from 5539ac7 to fa3fe90 Compare August 9, 2024 06:49
ekohl
ekohl reviewed Aug 9, 2024
View reviewed changes
spec/acceptance/settings_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/settings_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/settings_spec.rb Outdated Show resolved Hide resolved
@Scnaeg Scnaeg force-pushed the configure_auth_backend_classes branch from fa3fe90 to 8d83ea9 Compare August 9, 2024 10:19
@Scnaeg
Copy link
Contributor Author

Scnaeg commented Aug 9, 2024

Thank you very much for the review and I'm so sorry for the leftovers. Definitely not my day...

@ekohl ekohl enabled auto-merge (rebase) August 9, 2024 19:38
@ekohl ekohl merged commit ea88d5e into theforeman:master Aug 9, 2024
5 of 17 checks passed
@Odilhao
Copy link
Member

Odilhao commented Aug 10, 2024

The tests for 3.39, 3.49 and nightly failed after this merge, not sure if it's related.

https://community.theforeman.org/t/pulpcore-nightly-rpm-pipeline-395-failed/39058

@evgeni
Copy link
Member

evgeni commented Aug 12, 2024 •
edited
Loading

Well, CI was broken due to a syntax error: #349, but GitHub still decided it's a good idea to auto-merge this, even if the required check didn't pass 🙈

I think this should also fix pulpcore RPM CI

@ekohl
Copy link
Member

ekohl commented Aug 12, 2024

This isn't the first time auto-merge ignores a required check. At this point I really don't trust GH's auto-merge anymore.

@evgeni
Copy link
Member

evgeni commented Aug 12, 2024

Yeah 😢

https://ci.theforeman.org/job/pulpcore-nightly-rpm-pipeline/ is green at least again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Scnaeg @Odilhao @evgeni @ekohl