explicitly support Pulpcore 3.49 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Aug 14, 2024
manifests/repo.pp
Outdated
| @@ -8,7 +8,7 @@ | |||
| # An optional value for gpgkey to be used for yumrepo, instead of the default. | |||
| # If an empty string is passed, gpgcheck will be disabled. | |||
| class pulpcore::repo ( | |||
| Variant[Enum['nightly'], Pattern['^\d+\.\d+$']] $version = '3.39', | |||
| Variant[Enum['nightly'], Pattern['^\d+\.\d+$']] $version = '3.49', | |||
There was a problem hiding this comment.
does this make it a breaking change? 🤔
There was a problem hiding this comment.
people using include pulpcore::repo will get upgraded to 3.49?
There was a problem hiding this comment.
We should be able to safe drop 3.39 when the new katello get branched.
There was a problem hiding this comment.
I'd say it technically is a backwards incompatible change: it's declared as a public API and changes behavior in something that would be surprising to me as a user.
Short term I'd prefer to not change this line to avoid a major version bump. Then after that we can drop the default version. Then we may need to add some fallback here:
Because that's the biggest reason we have a default: so you can simply run beaker locally without specifying a version and still get some test suite to run. We could make that default to nightly.
ekohl
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.