Reuse headers from pulpcore::apache class

[ekohl]

We have the exact same code in both pulpcore::plugin::container as in pulpcore::apache. This reuses the variables rather than duplicating the logic.

Fixes: 21aa39e ("Fixes #37308 - set REMOTE_USER properly for pulpcore registry")

[ekohl]

I debated introducing a new variable that has both these values, but decided against it to keep this smaller.

[ekohl]

When adding tests I figured out that at least there it's somehow different.

Redoing it, I first wrote tests prior to this patch (e3d1ddb, based on @evgeni's work elsewhere). Then reapplied this (bd1dbec) and fixed tests the (66b97fe).

Why does it result in an additional line when it should use the exact same variables? Still trying to figure that out.

[evgeni]

Why does it result in an additional line when it should use the exact same variables? Still trying to figure that out.

Because the content of the variables are not identical!

The "global" ones:

puppet-pulpcore/manifests/apache.pp

Lines 48 to 55 in 5b6d088

	$api_default_request_headers = [
	"unset ${remote_user_environ_header}",
	"set ${remote_user_environ_header} \"%{SSL_CLIENT_S_DN_CN}s\" env=SSL_CLIENT_S_DN_CN",
	]
	$api_additional_request_headers = $pulpcore::api_client_auth_cn_map.map |String $cn, String $pulp_user| {
	"set ${remote_user_environ_header} \"${pulp_user}\" \"expr=%{SSL_CLIENT_S_DN_CN} == '${cn}'\""
	}

The ones you removed here:

puppet-pulpcore/manifests/plugin/container.pp

Lines 12 to 18 in c63cb65

	$api_default_request_headers = [
	"unset ${pulpcore::apache::remote_user_environ_header}",
	]
	$api_additional_request_headers = $pulpcore::api_client_auth_cn_map.map |String $cn, String $pulp_user| {
	"set ${pulpcore::apache::remote_user_environ_header} \"${pulp_user}\" \"expr=%{SSL_CLIENT_S_DN_CN} == '${cn}'\""
	}

the global ones, that we now use have an additional

"set ${remote_user_environ_header} \"%{SSL_CLIENT_S_DN_CN}s\" env=SSL_CLIENT_S_DN_CN", 

[ekohl]

I was so blindly staring at api_additional_request_headers that I didn't look too carefully at api_default_request_headers.

[ekohl]

#356