-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wants=postgresql.service to Pulpcore service files #359
Conversation
Wants is a weak requirement, so the service won't fail it can't be started but systemd will at least try it. That should work with help when postgresql is local.
I'd not add a hard requires |
@@ -1,7 +1,7 @@ | |||
[Unit] | |||
Description=Pulp Worker | |||
After=network-online.target | |||
Wants=network-online.target | |||
Wants=network-online.target postgresql.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this file I debated adding Redis as well, but wasn't quite sure about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense (also to foreman and dynflow)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense!
A user reported on Discourse that this wasn't sufficient to stop the coredumps when stopping Pulpcore: https://community.theforeman.org/t/pulpcore-coredumps-during-stopping-services/36512/6 |
We've identified this is still useful even if it does not address the particular problem discussed, which @evgeni has made headway with actually fixing through packaging. |
@ehelms while I was out, has additional testing been done on the stronger requirement, which was also suggested in https://community.theforeman.org/t/pulpcore-coredumps-during-stopping-services/36512/6? |
Wants is a weak requirement, so the service won't fail it can't be started but systemd will at least try it. That should work with help when postgresql is local.
This was reported in theforeman/foreman_maintain#824. I don't know if this is sufficient or if foreman_maintain also needs to be smarter.
An open question: if we know PostgreSQL is managed, should we make it a hard
Requires=
instead?