Refs #28720 - move migration params into migration plugin #63
Conversation
|
A test for this would be nice to have. |
Thanks for the comment, @ehelms The previous commit added a spec test for the migration plugin, https://github.com/theforeman/puppet-pulpcore/blob/master/spec/classes/plugin_migration_spec.rb , which tests the default values of the params. Is it better to test using non-default instead? |
| "ssl_certfile": "<%= scope['pulpcore::mongo_db_ssl_certfile'] %>", | ||
| "verify_ssl": "<%= scope['pulpcore::mongo_db_verify_ssl'] %>", | ||
| "ca_path": "<%= scope['pulpcore::mongo_db_ca_path'] %>", | ||
| "name": "<%= scope['pulpcore::plugin::migration::mongo_db_name'] %>", |
There was a problem hiding this comment.
For future reference, these variables are now in scope so you can use @mongodb_db_name
| Optional[String] $mongo_db_username = undef, | ||
| Optional[String] $mongo_db_password = undef, | ||
| Optional[String] $mongo_replica_set = undef, | ||
| String $mongo_db_ssl = 'False', |
There was a problem hiding this comment.
We should be using real booleans and only translate them in the templates. For example here Boolean $mongo_db_ssl = false. Then in the template <%= @mongo_db_ssl ? 'True' : 'False' %>. The same goes for the ssl verify parameter.
| String $mongo_db_seeds = 'localhost:27017', | ||
| Optional[String] $mongo_db_username = undef, | ||
| Optional[String] $mongo_db_password = undef, | ||
| Optional[String] $mongo_replica_set = undef, |
There was a problem hiding this comment.
This parameter doesn't match the documentation which is for mongo_db_replica_set.
No description provided.