Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #28901 - support external postgresql #64

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Fixes #28901 - support external postgresql #64

merged 1 commit into from
Feb 10, 2020

Conversation

wbclark
Copy link
Collaborator

@wbclark wbclark commented Feb 7, 2020 •
edited by ekohl
Loading

Fixes GH-4

@wbclark wbclark force-pushed the external_postgres branch 5 times, most recently from 33f1446 to 346638e Compare February 7, 2020 05:46
ehelms
ehelms reviewed Feb 7, 2020
View reviewed changes
manifests/database.pp Outdated Show resolved Hide resolved
@wbclark wbclark force-pushed the external_postgres branch 3 times, most recently from 8fa6b4f to 1329c31 Compare February 7, 2020 21:47
ekohl
ekohl reviewed Feb 8, 2020
View reviewed changes
spec/classes/pulpcore_spec.rb Outdated Show resolved Hide resolved
ekohl
ekohl reviewed Feb 8, 2020
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
ekohl
ekohl requested changes Feb 10, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but will SSL/TLS be relevant?

spec/classes/pulpcore_spec.rb Outdated Show resolved Hide resolved
ekohl
ekohl requested changes Feb 10, 2020
View reviewed changes
spec/classes/pulpcore_spec.rb Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@ekohl ekohl merged commit 752adcf into theforeman:master Feb 10, 2020
@wbclark wbclark added the Enhancement New feature or request label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms left review comments

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specification of externally managed PostgreSQl instance
3 participants
@wbclark @ekohl @ehelms