fixed default params #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Nov 21, 2019
wbclark
force-pushed
the
fixdefaults
branch
2 times, most recently
from
5fbf34b to
d996a5c
Compare
ekohl
reviewed
Nov 26, 2019
wbclark
force-pushed
the
fixdefaults
branch
2 times, most recently
from
1a173f0 to
dafdf5e
Compare
ekohl
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have:
Changed default user, group, and paths to use 'pulp' instead of 'pulpcore' as required by the migration tool
Shorted parameter names by removing redundant 'pulp_' prefixes
Commented parameters in manifests/init.pp
Added random generation of DB password