Fixes #29075 - add pulp_rpm plugin #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As expected at this time, it's failing to find a package to install: Although the package name is probably not correct, but I don't find under any other name in http://koji.katello.org/releases/yum/katello-nightly/pulpcore/el7/x86_64/ either. @evgeni could you direct me where to find it, if it exists at this point? I did see theforeman/foreman-packaging#4191 was merged, hence my confusion on the topic. Thanks! |
|
The python plugin was not packaged yet |
wbclark
force-pushed
the
rpm_plugin
branch
2 times, most recently
from
88bd025 to
2d0e0aa
Compare
ehelms
reviewed
May 8, 2020
|
I updated to have the correct plugin/package name but I'm still anticipating a failure based on what I observed when I tried manually installing it. |
ekohl
requested changes
May 11, 2020
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
wbclark
force-pushed
the
rpm_plugin
branch
2 times, most recently
from
546bb7a to
fc9779e
Compare
|
Looks like now it's having issues on EL7 and EL8 with finding solv even though that is packaged and in the repository: I'll try to debug it. |
|
When you start a python3 shell, can you run the following: import pkg_resources
import solv
pkg_resources.get_distribution('solv')And post the output? |
|
Looks similar: |
|
If it helps: |
Indeed. It's missing the egg files, which seem not to be built by cmake for some reason. |
|
@evgeni another related issue to how the python package was created? |
|
@ehelms we're probably missing a |
|
Oh, no, our libmodulemd is too old. Fuck. |
|
The libmodulemd issue is now resolved, right @evgeni ? theforeman/foreman-packaging@764bec8 |
no, that's the "solv" fix, not the "modulemd" fix. you can watch me throwing tables on twitch if you like :) |
|
modulemd might be fixed by theforeman/foreman-packaging#5355 @ehelms can I easily test that with a scratch build? |
|
alternative to test this, w/o the fixed build: install libmodulemd (on el8) or libmodulemd2 (on el7) manually/via puppet |
|
btw, I don't understand the EL8 failure: but >>> import pkg_resources
>>> pkg_resources.get_distribution('libcomps~=0.1.11')
libcomps 0.1.15 (/usr/lib64/python3.6/site-packages) |
|
El7 is at least happy. I do not understand that EL8 failure myself either. |
|
It tells us that python3-libcomps is not installed, which is not possible? |
|
Hah, the python3-libcomps from centos does not have am egg info. This would explain the error. But we ship this package ourself on el8... But if it's already installed, we wouldn't update it (in yum/puppet), as it's new enough. yeah, that must be it. |
|
Yepp, only 0.1.12 got an egg: rpm-software-management/libcomps@972ba0a We could artificially bump the dep to .12 or do the same trick as we did for solv. @ehelms preferences? |
|
Do we ship a new enough version? If so, I think I'd prefer to add a version requirement that's |
|
I don't think I understand the tradeoffs. Given that, follow the pattern we
did with solv is my vote. Whatever is easiest/least Jacky.
Do we need to file an issue with libcomps project?
…On Wed, Jun 3, 2020, 3:30 PM Evgeni Golov ***@***.***> wrote:
Yepp, only 0.1.12 got an egg: ***@***.***
<rpm-software-management/libcomps@972ba0a>
We could artificially bump the dep to .12 or do the same trick as we did
for solv.
@ehelms <https://github.com/ehelms> preferences?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHT46DW4WKE3LZKBSI37TRU2QGBANCNFSM4MDKIJ3Q>
.
|
|
@ehelms there is no issue with libcomps, as their newer versions provide the egg, just not the one in EL8 proper (but the one we ship). |
|
And now it's modulemd on EL8, ffs. |
|
because, you know, it works in my container: [root@315aeea31b8a /]# python3
Python 3.6.8 (default, May 21 2019, 23:51:36)
[GCC 8.2.1 20180905 (Red Hat 8.2.1-3)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import gi
>>> gi.require_version('Modulemd', '2.0')
>>> |
|
GREEEN! |
ehelms
reviewed
Jun 4, 2020
ehelms
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.