Update pulpcore::admin to use the command parameter if it is passed #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Apr 13, 2020
|
It looks like the tests need to be updated. |
wbclark
reviewed
Apr 13, 2020
| @@ -40,7 +40,7 @@ | |||
|
|
|||
| it do | |||
| is_expected.to compile.with_all_deps | |||
| is_expected.to contain_exec('python3-django-admin help') | |||
| is_expected.to contain_exec('python3-django-admin migrate --noinput') | |||
There was a problem hiding this comment.
Looks good. In fact, when I scroll up a few lines I can see that this is what it should have been all along.
|
Thanks for the contribution @gcoxmoz ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-pulpcore
that referenced
this pull request
Aug 9, 2022
…heforeman#91) Update pulpcore::admin to use the command parameter if it is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pulpcore::admin, there is a
$commandparameter that defaults to$title. However,$commandis never used, and${title}is used inside an exec where the $command ought to be.