Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over code from puppet-foreman #1

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Apr 24, 2020

These files were part of puppet-foreman but now become a standalone module. This makes it easier to test.

Various fixes were made to get tests to pass properly in the new layout and with the additional operating systems. No actual code was changed.

metadata.json Outdated Show resolved Hide resolved
metadata.json Outdated Show resolved Hide resolved
@mmoll
Copy link

mmoll commented Apr 24, 2020

Could travis get activated for this repo?

@ekohl
Copy link
Member Author

ekohl commented Apr 24, 2020

Done. Now it fails because it needs facterdb 1.3.0: voxpupuli/voxpupuli-test@0c27534

@ekohl
Copy link
Member Author

ekohl commented Apr 24, 2020

Argh, only tested with Puppet 6 and that was green. Will get to this later.

@mmoll
Copy link

mmoll commented May 4, 2020

Also needs a rebase now :)

@ekohl ekohl marked this pull request as draft May 4, 2020 17:39
@ekohl
Copy link
Member Author

ekohl commented May 4, 2020

Due to time constraints I'll get back to this once Foreman 2.1 is branched

@ekohl ekohl marked this pull request as ready for review June 24, 2020 14:20
@ekohl
Copy link
Member Author

ekohl commented Jun 24, 2020

Rebased and updated

These files were part of puppet-foreman but now become a standalone
module. This makes it easier to test.

Various fixes were made to get tests to pass properly in the new layout
and with the additional operating systems. No actual code was changed.
@ehelms ehelms merged commit dc6257d into theforeman:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants