Fixes 7104 - make sure qpidd is really running after service starts

[iNecas]

No description provided.

[waldenraines]

I am testing this currently.

[waldenraines]

I applied the changes from this PR as well as theforeman/puppet-certs#33 and I get the following errors:

 qpid-config --ssl-certificate /etc/pki/katello/certs/java-client.crt --ssl-key /etc/pki/katello/private/java-client.key -b 'amqps://[redacted]:5671' add exchange topic event --durable returned 1 instead of one of [0]
 /Stage[main]/Certs::Candlepin/Exec[create candlepin qpid exchange]/returns: change from notrun to 0 failed: qpid-config --ssl-certificate /etc/pki/katello/certs/java-client.crt --ssl-key /etc/pki/katello/private/java-client.key -b 'amqps://[redacted]:5671' add exchange topic event --durable returned 1 instead of one of [0]
 /Stage[main]/Candlepin::Service/Exec[cpinit]: Failed to call refresh: /usr/bin/wget --timeout=30 --tries=5 --retry-connrefused -qO- http://localhost:8080/candlepin/admin/init >/var/log/candlepin/cpinit.log 2>&1 && touch /var/lib/candlepin/cpinit_done returned 4 instead of one of [0]
 /Stage[main]/Candlepin::Service/Exec[cpinit]: /usr/bin/wget --timeout=30 --tries=5 --retry-connrefused -qO- http://localhost:8080/candlepin/admin/init >/var/log/candlepin/cpinit.log 2>&1 && touch /var/lib/candlepin/cpinit_done returned 4 instead of one of [0]
 /Stage[main]/Foreman::Database/Foreman::Rake[db:seed]/Exec[foreman-rake-db:seed]: Failed to call refresh: /usr/sbin/foreman-rake db:seed returned 1 instead of one of [0]
 /Stage[main]/Foreman::Database/Foreman::Rake[db:seed]/Exec[foreman-rake-db:seed]: /usr/sbin/foreman-rake db:seed returned 1 instead of one of [0]

Here are my changes:

[walden@[redacted] ~]$ grep -n -B 3 qpidd /usr/share/katello-installer/modules/certs/manifests/candlepin.pp 
77-      command     => "certutil -A -d '${::certs::nss_db_dir}' -n 'amqp-client' -t ',,' -a -i '${client_cert}'",
78-      refreshonly => true,
79-      subscribe   => Exec['create-nss-db'],
80:      notify      => Service['qpidd'],
--
88-    exec { 'create candlepin qpid exchange':
89-      command => "qpid-config --ssl-certificate ${client_cert} --ssl-key ${client_key} -b 'amqps://${::fqdn}:5671' add exchange topic event --durable",
90-      unless  => "qpid-config --ssl-certificate ${client_cert} --ssl-key ${client_key} -b 'amqps://${::fqdn}:5671' exchanges event",
91:      require => Service['qpidd'],
[walden@[redacted] ~]$ cat /usr/share/katello-installer/modules/service_wait/plugins/qpidd.sh
confine [ $SERVICE = 'qpidd' ]

QPID_PORT=${QPID_PORT:-5671}

service-wait () {
    wait-for-port $QPID_PORT
}

[iNecas]

Please send me full installer logs, I haven't hit this errors when testing

[waldenraines]

This worked for me once I had everything set up correctly, ACK.