mark *_url settings as required and remove their default values #43
Conversation
evgeni
force-pushed
the
pulp-urls
branch
3 times, most recently
from
89b99ed to
83e0df0
Compare
|
These defaults are sort of development values. and I always assumed people would set this explicitly because I don't trust autodetection. |
I think the only way to enforce that is to not have a default value and ensure users think about / set this value. I would tend to prefer no default value other than a default specified in the settings file. |
|
If there is no sane default, don't have one in the first place. That makes a lot of sense to me. |
|
I guess the sanity is debatable, yeah. Would y'all prefer if I'd just drop the localhost default values, and mark the settings as required? |
|
Works for me. Saves doing these lookups regardless of whether a setting is configured (which can fail or slow things down) |
evgeni
changed the title
evgeni
force-pushed
the
pulp-urls
branch
2 times, most recently
from
3ae8824 to
d0f3f3b
Compare
evgeni
force-pushed
the
pulp-urls
branch
2 times, most recently
from
8b75895 to
44ad191
Compare
Those URLs are used by Katello and clients to connect to Pulp and `localhost` is almost never the right choice here as it will be either not reachable (for clients) or have the wrong certs (for Katello). Guessing the right URL is hard, so let's not do that and force the user to set it instead.
|
Why are some errors using "Parameter" and some "Setting"? :D |
|
Being consistent is hard? |
Those URLs are used by Katello and clients to connect to Pulp and
localhostis almost never the right choice here as it will be eithernot reachable (for clients) or have the wrong certs (for Katello).
Guessing the right URL is hard, so let's not do that and force the user
to set it instead