Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constructor name to determine if a function is a generator function #77

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

jnicklas
Copy link
Collaborator

If we are using a polyfill runtime for generators, the constructors might not be identical. Using the name is a bit hacky, but it's the best we got.

@frontsidejack
Copy link
Member

A preview package of this pull request has been released to NPM with the tag generator-function-by-constructor-name.
You can try it out by running the following command:

$ npm install effection@generator-function-by-constructor-name

or by updating your package.json to:

{
  "effection": "generator-function-by-constructor-name"
}

Once the branch associated with this tag is deleted (usually once the PR is merged or closed), it will no longer be available. However, it currently references effection@0.5.0-cc3e841 which will be available to install forever.

Generated by 🚫 dangerJS against ee4b07d

If we are using a polyfill runtime for generators, the constructors
might not be identical. Using the name is a bit hacky, but it's the best
we got.
@jnicklas jnicklas force-pushed the generator-function-by-constructor-name branch from ee4b07d to 5683f69 Compare February 24, 2020 18:19
@frontsidejack
Copy link
Member

A preview package of this pull request has been released to NPM with the tag generator-function-by-constructor-name.
You can try it out by running the following command:

$ npm install effection@generator-function-by-constructor-name

or by updating your package.json to:

{
  "effection": "generator-function-by-constructor-name"
}

Once the branch associated with this tag is deleted (usually once the PR is merged or closed), it will no longer be available. However, it currently references effection@0.5.0-1851748 which will be available to install forever.

Generated by 🚫 dangerJS against 5683f69

@cowboyd cowboyd merged commit 0060258 into master Feb 24, 2020
@cowboyd cowboyd deleted the generator-function-by-constructor-name branch February 24, 2020 22:04
@github-actions github-actions bot restored the generator-function-by-constructor-name branch February 24, 2020 22:05
@frontsidejack
Copy link
Member

A preview package of this pull request has been released to NPM with the tag generator-function-by-constructor-name.
You can try it out by running the following command:

$ npm install effection@generator-function-by-constructor-name

or by updating your package.json to:

{
  "effection": "generator-function-by-constructor-name"
}

Once the branch associated with this tag is deleted (usually once the PR is merged or closed), it will no longer be available. However, it currently references effection@0.5.0-3e483c1 which will be available to install forever.

Generated by 🚫 dangerJS against 131b1c8

@cowboyd cowboyd deleted the generator-function-by-constructor-name branch March 30, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants