Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a plain <input> instead of {{input}} #48

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

cibernox
Copy link
Contributor

@cibernox cibernox commented Jan 4, 2017

I've found some problems in 2.10 and safari with the {{input type="file"}}. For some unknown reason the first time an {{x-file-input}} is rendered the type of the input is text, not file. It does work after a reload or after transitioning to ther area and coming back.

This is clearly a bug in Ember, but there is no reason to use {{input}} when <input> is faster and does also bypasses any bug in the {{input}} component might introduce.

@cowboyd cowboyd merged commit 8139703 into adopted-ember-addons:master Jan 4, 2017
@cowboyd
Copy link
Collaborator

cowboyd commented Jan 4, 2017

Thanks @cibernox! Remove complexity, gain functionality. That's always a favorable equation :)

@cibernox
Copy link
Contributor Author

cibernox commented Jan 4, 2017

@cowboyd Ping me if you cut a new version so I stop using my fork.

@Robdel12
Copy link
Collaborator

Robdel12 commented Jan 4, 2017

@cibernox just cut a new release! 👍 Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants