-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextField component file type setting in Safari 10.0 #14727
Comments
After more investigation, the problem is isolated to file types. Safari does not allow creating an input type and changing it to "file".
|
Seems like a bug, second input for |
You cannot create an element and change it's type from * to "file". See: emberjs#14727 for more details
FWIW, I also found this problem yesterday in For more weirdness, I found that this only happened the first time I rendered the view with the error. If I transitioned somewhere else and then come back it worked again. |
I can also reproduce and it does seem to depend on the ordering of the types of CC @jamesarosen. |
You cannot create an element and change it's type from * to "file". See: emberjs#14727 for more details
# This is the 1st commit message: typo in comment # The commit message #2 will be skipped: # indent yuidoc comment # The commit message #3 will be skipped: # remove IE8 test # The commit message #4 will be skipped: # remove commented out test # The commit message #5 will be skipped: # use file path and add imports # # Used RFC #176 modules API for imports. # Also cleaned up some of the globals-mode usage. # The commit message #6 will be skipped: # clean up more globals style documentation # The commit message #7 will be skipped: # Updates blueprints # The commit message #8 will be skipped: # remove extra type check # The commit message #9 will be skipped: # [BUGFIX beta] Reusing element causes problems in Safari # # When testing allowed input types, in some versions of Safari the type # cannot be change to `file` if previously set to a different one. # # Fixes #14727 # The commit message #10 will be skipped: # [DOC release]missed code block added # The commit message #1 will be skipped: # [DOC release] Update wait.js - Add missing backticks to code snippet. # The commit message #2 will be skipped: # use safe `toString` for array content in `mixins/array` # The commit message #3 will be skipped: # avoid expanding already expanded property key in computed.sort # The commit message #4 will be skipped: # avoid expanding already expanded property key in reduceMacro/arrayMacro/multiArrayMacro # The commit message #5 will be skipped: # [DOC release] Make `Ember.expandProperties` public # The commit message #6 will be skipped: # reuse meta `arrayContentDidChange` # The commit message #7 will be skipped: # replace `throw` with assertion in `enumerable` # The commit message #8 will be skipped: # [BUGFIX beta] Allow boolean values for current-when # # As the docs say, `A link will be active if current-when is true`. # Looks like this might have been broken since 1.13 and #12344 # did not seem to actually fix this particular bug. # # Related issues: # # - #12512 # - #12630 (fix was not merged) # - #12296 # The commit message #9 will be skipped: # remove unused imports # The commit message #10 will be skipped: # [DOC] Improve Ember.isEmpty # The commit message #1 will be skipped: # micro optimization in `enumerable`
Ember version > 2.10
Safari version tested: 10.0.1
Reproducible: Every time -> https://ember-twiddle.com/aa37dcf277451f5954d6ca2d17e16dc6?openFiles=templates.application.hbs%2C
Issue: When rendering multiple textfield components on a page, only the first type will be allowed on the page
. The set of the test element .type property successfully returns however the type actually doesn't alter the value of the property.
Problem line:
ember.js/packages/ember-glimmer/lib/components/text_field.js
Line 32 in 7819409
Possible solution: Lowering the scope of inputTypeTestElement to inside the method resolves the problem, but I assume it was scoped for performance reasons.
The text was updated successfully, but these errors were encountered: