[BUGFIX beta] File element type #14753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anon4562 sorry for letting this sit, can you add a test? |
|
☔ The latest upstream changes (presumably #15002) made this pull request unmergeable. Please resolve the merge conflicts. |
Serabe
force-pushed
the
file-element-type
branch
from
5ae0606
to
f9d01b6
Compare
|
Rebased and added a test. The problem cannot be reproduced in Safari 10.1.2 though. |
|
Something went really wrong with the tests. Into it. |
Serabe
force-pushed
the
file-element-type
branch
from
f9d01b6
to
202c5ab
Compare
|
My test was wrong. I was testing that an input element can change from any type to file type while the issue was testing the type is supported. I changed this to render two inputs, being the file one the second one. Sorry! |
When testing allowed input types, in some versions of Safari the type cannot be change to `file` if previously set to a different one. Fixes emberjs#14727
Serabe
force-pushed
the
file-element-type
branch
from
202c5ab
to
388fac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot create an element and change it's type from * to "file".
See: #14727 for more details