[BUGFIX release] allow current-when to be a boolean #12512 #12630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the condition in invoke helper assertions to throw on helpers extending `Ember.Helper`. Fixes emberjs#12804
[BUGFIX beta] Make container always return the same value even if the registered value is falsy
[BUGFIX beta] Fix block behaviour for `Helper.extend` helpers
|
Can you rebase? |
|
@rwjblue: I think I messed up somewhere. Rebasing did not work out the way I intended too. Can you apply ssured@b831b6e ? Then I will revoke this PR and all should be well again. |
|
Was fixed by #12344 |
whatthewhat
added a commit
to whatthewhat/ember.js
that referenced
this pull request
Jan 18, 2017
As the docs say, `A link will be active if current-when is true`. Looks like this might have been broken since 1.13 and emberjs#12344 did not seem to actually fix this particular bug. Related issues: - emberjs#12512 - emberjs#12630 (fix was not merged) - emberjs#12296
whatthewhat
added a commit
to whatthewhat/ember.js
that referenced
this pull request
Jun 26, 2017
As the docs say, `A link will be active if current-when is true`. Looks like this might have been broken since 1.13 and emberjs#12344 did not seem to actually fix this particular bug. Related issues: - emberjs#12512 - emberjs#12630 (fix was not merged) - emberjs#12296
locks
added a commit
that referenced
this pull request
Aug 16, 2017
# This is the 1st commit message: typo in comment # The commit message #2 will be skipped: # indent yuidoc comment # The commit message #3 will be skipped: # remove IE8 test # The commit message #4 will be skipped: # remove commented out test # The commit message #5 will be skipped: # use file path and add imports # # Used RFC #176 modules API for imports. # Also cleaned up some of the globals-mode usage. # The commit message #6 will be skipped: # clean up more globals style documentation # The commit message #7 will be skipped: # Updates blueprints # The commit message #8 will be skipped: # remove extra type check # The commit message #9 will be skipped: # [BUGFIX beta] Reusing element causes problems in Safari # # When testing allowed input types, in some versions of Safari the type # cannot be change to `file` if previously set to a different one. # # Fixes #14727 # The commit message #10 will be skipped: # [DOC release]missed code block added # The commit message #1 will be skipped: # [DOC release] Update wait.js - Add missing backticks to code snippet. # The commit message #2 will be skipped: # use safe `toString` for array content in `mixins/array` # The commit message #3 will be skipped: # avoid expanding already expanded property key in computed.sort # The commit message #4 will be skipped: # avoid expanding already expanded property key in reduceMacro/arrayMacro/multiArrayMacro # The commit message #5 will be skipped: # [DOC release] Make `Ember.expandProperties` public # The commit message #6 will be skipped: # reuse meta `arrayContentDidChange` # The commit message #7 will be skipped: # replace `throw` with assertion in `enumerable` # The commit message #8 will be skipped: # [BUGFIX beta] Allow boolean values for current-when # # As the docs say, `A link will be active if current-when is true`. # Looks like this might have been broken since 1.13 and #12344 # did not seem to actually fix this particular bug. # # Related issues: # # - #12512 # - #12630 (fix was not merged) # - #12296 # The commit message #9 will be skipped: # remove unused imports # The commit message #10 will be skipped: # [DOC] Improve Ember.isEmpty # The commit message #1 will be skipped: # micro optimization in `enumerable`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring current-when in line with the docs
Sorry but I created this PR from within Github, as a start. My testing experience is not enough to create a test and run it locally on my machine. Hope this helps though...