Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add idp create action #116

Merged
merged 3 commits into from
Oct 14, 2022
Merged

add idp create action #116

merged 3 commits into from
Oct 14, 2022

Conversation

dagda1
Copy link
Contributor

@dagda1 dagda1 commented Oct 14, 2022

Motivation

We want to scaffold a template from the idp CLI

Approach

Add a new action to the cli that accepts eight yaml from stdin or a file and post the values to the baskstage scaffolder.

@dagda1 dagda1 requested a review from a team October 14, 2022 19:44
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

⚠️ No Changeset found

Latest commit: a4f4876

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dagda1 dagda1 changed the base branch from main to idp-plugins October 14, 2022 19:46
@dagda1 dagda1 requested review from taras and cowboyd October 14, 2022 19:46
taras
taras approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Enjoy your vacation!

@taras taras merged commit b56a521 into idp-plugins Oct 14, 2022
@taras taras deleted the pc/scaffolder-create branch October 14, 2022 19:50
taras pushed a commit that referenced this pull request Oct 31, 2022
@dagda1 @taras
add idp create action (#116)
51a4d2d 
* add scaffold cli action

* rename scaffold to create

* allow yaml argument to create from file or stdin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taras taras taras approved these changes

@cowboyd cowboyd Awaiting requested review from cowboyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagda1 @taras