Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace logger by structlog #718

Merged
merged 5 commits into from
Jun 17, 2024
Merged

refactor: replace logger by structlog #718

merged 5 commits into from
Jun 17, 2024

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Jun 13, 2024

BREAKING CHANGE: Replace the custom logger and python-json-logger with structlog. This will also change the layout and general structure of the log messages.

The original python-json-logger package is unmaintained and has caused some issues. Using https://github.com/nhairs/python-json-logger.git instead has fixed the logging issues but prevents PyPI package uploads...

HTTP Error 400: Can't have direct dependency: python-json-logger@ git+https://github.com/nhairs/python-json-logger.git@v3.1.0. See https://packaging.python.org/specifications/core-metadata for more information.

@xoxys xoxys marked this pull request as draft June 13, 2024 07:10
@xoxys xoxys marked this pull request as ready for review June 13, 2024 17:11
@xoxys xoxys merged commit 8e22e87 into main Jun 17, 2024
5 checks passed
@xoxys xoxys deleted the structlog branch November 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant