fix: replace deprecated ruamel.yaml.safe_load (#161)

docs/content/configuration/defaults.md

@@ -34,7 +34,7 @@ exclude_tags: []
 pve:
     server:
     user:
-    password
+    password:
     auth_timeout: 5
     verify_ssl: true
 

prometheuspvesd/config.py

@@ -211,7 +211,7 @@ def _set_config(self):
                 with open(config, "r", encoding="utf8") as stream:
                     s = stream.read()
                     try:
-                        file_dict = ruamel.yaml.safe_load(s)
+                        file_dict = ruamel.yaml.YAML(typ="safe", pure=True).load(s)
                     except (
                         ruamel.yaml.composer.ComposerError, ruamel.yaml.scanner.ScannerError
                     ) as e:

prometheuspvesd/test/data/config.yml

@@ -0,0 +1,24 @@
+---
+logging:
+  level: warning
+  format: console
+
+metrics:
+  enabled: true
+  address: "127.0.0.1"
+  port: 8000
+
+output_file: dummy
+loop_delay: 300
+service: true
+
+exclude_state: []
+exclude_vmid: []
+exclude_tags: []
+
+pve:
+  server: proxmox.example.com
+  user: root
+  password: secure
+  auth_timeout: 5
+  verify_ssl: true

prometheuspvesd/test/fixtures/fixtures.py

@@ -127,9 +127,9 @@ def defaults():
         "output_file": "dummy",
         "pve": {
             "auth_timeout": 5,
-            "password": "dummypass",
-            "server": "dummyserver",
-            "user": "dummyuser",
+            "password": "",
+            "server": "",
+            "user": "",
             "verify_ssl": True
         },
         "service": True,

prometheuspvesd/test/unit/test_config.py

@@ -0,0 +1,35 @@
+"""Test Config class."""
+import pytest
+import ruamel.yaml
+
+import prometheuspvesd.exception
+from prometheuspvesd.config import Config
+
+pytest_plugins = [
+    "prometheuspvesd.test.fixtures.fixtures",
+]
+
+
+def test_yaml_config(mocker, defaults):
+    mocker.patch(
+        "prometheuspvesd.config.default_config_file", "./prometheuspvesd/test/data/config.yml"
+    )
+    config = Config()
+
+    defaults["pve"]["user"] = "root"
+    defaults["pve"]["password"] = "secure"
+    defaults["pve"]["server"] = "proxmox.example.com"
+
+    assert config.config == defaults
+
+
+def test_yaml_config_error(mocker, capsys):
+    mocker.patch(
+        "prometheuspvesd.config.default_config_file", "./prometheuspvesd/test/data/config.yml"
+    )
+    mocker.patch.object(ruamel.yaml.YAML, "load", side_effect=ruamel.yaml.composer.ComposerError)
+
+    with pytest.raises(prometheuspvesd.exception.ConfigError) as e:
+        Config()
+
+    assert "Unable to read config file ./prometheuspvesd/test/data/config.yml" in str(e.value)