Fix HTTP 207 didn't handled properly #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just fixed some tests in master. Could you merge master into your branch to make sure tests are still passing? |
GHA not configured for PR? |
|
I've added a condition to trigger on PRs. Could you merge master again? |
|
guillaume-tgl
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My environment:
nginx/1.18.0 (Ubuntu),sardine-android:0.8On Nginx WebDAV server, if you send a
PROPFINDrequest, it will return a HTTP 207 response listing all possible files. But in my case,sardine.existschecks only the HTTP status code <= 299 instead of parsing into the XML file.Since I don't want to implement a XML parser, I change this request to
HEADas the OG sardine did.