Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullability and comprehensive code checks - Validated #201

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

c19x
Copy link
Contributor

@c19x c19x commented Jun 1, 2021

  • Full coverage for @Nullable and @NonNull annotations for all methods
    • Explicit code checks for null are retained for backwards compatibility (code inspection warnings are suppressed)
  • Full coverage for "final" method parameters and constants
  • Full review and update/suppression of all code inspection warnings
  • Validated on Pixel3, Samsung A20 with iPhone X (14.2) and Denmark
  • Conducting overnight test for final validation following significant code updates, shall confirm test results as evidence for PR approval

Signed-off-by: c19x support@c19x.org

closes #200

- Full coverage for @nullable and @nonnull annotations for all methods
  - Explicit code checks for null are retained for backwards compatibility (code inspection warnings are suppressed)
- Full coverage for "final" method parameters and constants
- Full review and update/suppression of all code inspection warnings
- Validated on Pixel3, Samsung A20 with iPhone X (14.2) and Denmark

Signed-off-by: c19x <support@c19x.org>
@adamfowleruk adamfowleruk merged commit 803cb7c into theheraldproject:develop Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep improving Kotlin-Java Interop null safety, and constant parameters
2 participants