Completed all required issues in v2.1.0 milestone #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome client apps. Not a bug with Herald:- - Demo app requests FINE and COARSE location on Android up to and including v12 - If you do not ask for FINE grained location on Android 12, then it doesn't work. This contradicts Android's own documentation. (But has been verified in testing on a Pixel3XL) - If the user selects 'Approximate' instead of 'Precise' location, then similarly the didMeasure and didRead callbacks are never called - This is an Android documentation issue - The sample app code and Herald AndroidManifest.xml have had their explanations improved - Target SDK bumped from 30 (Android 11) to 31 (Android 12) - Build tools version bumped on demo app to the same as the Herald API (30.0.3) Signed-off-by: Adam Fowler <adam@adamfowler.org>
Signed-off-by: Adam Fowler <adam@adamfowler.org>
…document Bluetooth permissions Signed-off-by: Adam Fowler <adam@adamfowler.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Fowler adam@adamfowler.org