Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Code Folding extension causes Brackets editor to become unresponsive #55

Closed
dexbg opened this issue Apr 16, 2014 · 11 comments
Closed

Comments

@dexbg
Copy link

dexbg commented Apr 16, 2014

I just updated the Code Folding extension to its latest version and now when I start typing in the Brackets editor (i.e. edit HTML code) the editor becomes unresponsive for few seconds on each keystroke. I removed the Code Folding extension and the problem was not reproducible any more.

@dexbg dexbg changed the title Code folding extension causes Brackets editor to become unresponsive The Code folding extension causes Brackets editor to become unresponsive Apr 16, 2014
@dexbg dexbg changed the title The Code folding extension causes Brackets editor to become unresponsive The Code Folding extension causes Brackets editor to become unresponsive Apr 16, 2014
@thehogfather
Copy link
Owner

Thanks for reporting. Did you have a similar problem in javascript files? I noticed you mentioned editing html code in your comment.

@thehogfather
Copy link
Owner

If you are able to test, could you please download this branch and see if performance is improved? Thanks

@dexbg
Copy link
Author

dexbg commented Apr 17, 2014

Well, the problem does not occur when editing javascript files - I reproduce it only on HTML files.
I tested the problem using the latest branch but there is no difference. My environment is Brackets 38 on Windows 7 x64.

@thehogfather
Copy link
Owner

okay thanks I have tested on my virtual machine and I cannot reproduce the issue. At first I thought it might be because brackets now loads the xml-fold addon from codemirror - but that does not make a huge difference. Would you mind sharing your setup with respect to other extensions you have installed? Thanks again. I'd like to get this sorted.

@dexbg
Copy link
Author

dexbg commented Apr 17, 2014

Ok, this is the list of my installed extensions:
Beautify
Brackets Builder
Brackets cut line
Brackets Snippets
Code Folding
Command Runner
CSSLint
Emmet
Exclude Folders
File Navigation Shortcuts
Indentator
Interactive Linter
JSHint
JSLint Configurator
Node.js bindings
PHPLint for Brackets
Pretty Json
Quick Search
Rename JavaScript Identifier
Themes
Theseus for Brackets
WordHint
xUnit & Blanket

@peterflynn
Copy link

@thehogfather Note that the user in adobe/brackets#7549 seems to be saying the only two extensions they had installed were Brackets Code Folding and W3C Validation.

It also might be worth asking users for specific code samples of HTML files they're seeing the problem with -- it may only repro with certain constructs in the code, etc.

@thehogfather
Copy link
Owner

good shout @peterflynn.
@dexbg @aadamsx would you mind sharing (redacted or anonymised) code samples I can use to reproduce this issue?

@thehogfather
Copy link
Owner

@dexbg if you could try out the latest git version of the extension, and let me know if there are any improvements, that would be grand.

@dexbg
Copy link
Author

dexbg commented Apr 18, 2014

Well, I cannot reproduce the problem on Ubuntu 13.10. I guess it is Windows specific. During the holidays I don't have access to Windows machine therefore I can test the latest git version after few days. The code is here: http://garderobche.eu/gcdc2014/index.html (download index.html and try to edit it).

@thehogfather
Copy link
Owner

Thanks @dexbg. I was able to reproduce the problem on windows using your file. The latest git version of the extension seems to have fixed the issue. I am yet to investigate the actual root cause of the issue (e.g., why windows or indeed why merely loading the xml-fold addon from brackets seems to work). I shall post any findings on this thread later today.

@aadamsx
Copy link

aadamsx commented Apr 18, 2014

I went to GitHub and downloaded the latest version too (since as of yet, they have not posted the update in Extension Manager it seems). Things are a little faster, but the lag still persists at times. Also, I see the lag is still awful switching from file to file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants