This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Pack flag for /v2/observations #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- validation of queries in query controller - support for subscribed and subscriptionFreq Query parameters
- add query_diff table - add query_diff_entry table - update query table
Introduce new tables: - biomart_user.query_set - biomart_user.query_set_instances - biomart_user.query_set_diffs Use the new tables for storing user query related sets, instead of previously used i2b2demodata.qt_query_master and other patient_set related tables.
Docs clinical
Require the 'pack' flag for Protobuf output. Accepted values: 't' and 'f', but currently only 'f' is supported. This flag ensures we can add the packed protobuf output format without breaking compatibility in the future. If we decide to use packed or unpacked as the default, we can make this flag optional in the future.
forus
suggested changes
Mar 7, 2018
|
|
||
| if (args.type == null) throw new InvalidArgumentsException("Parameter 'type' is required") | ||
|
|
||
| if (args.pack != 'f' && contentFormat == Format.PROTOBUF) throw new InvalidArgumentsException( |
There was a problem hiding this comment.
@JanKanis What if pack is not specified. Isn't it better to have pack=f as default value?
Currently, there are many e2e tests that are failing because of that.
There was a problem hiding this comment.
The goal of this change was exactly to force clients to specify this flag. In that way in the future the endpoint can default to the 'best' representation (packed or unpacked), where 'best' is still to be decided, in the future without breaking compatiibility. But this was supposed to be part of the release, and AFAIK it had already been merged.
ewelinagr
force-pushed
the
dev
branch
3 times, most recently
from
93183e7 to
b651751
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require the 'pack' flag for Protobuf output. Accepted values: 't' and 'f', but currently only 'f' is supported.
This flag ensures we can add the packed protobuf output format without breaking compatibility in the future.
If we decide to use packed or unpacked as the default, we can make this flag optional in the future.