Add CSR test study #382
Add CSR test study #382
Conversation
forus
force-pushed
the
csr_study
branch
2 times, most recently
from
1218680 to
9d6c233
Compare
forus
force-pushed
the
csr_study
branch
2 times, most recently
from
2f8430b to
ed27b27
Compare
| 0 study | ||
| 1 concept | ||
| 2 patient | ||
| 3 DENSE CSR_DIAGNOSIS_MOD T Diagnosis ID NOT_PACKABLE SMALL |
There was a problem hiding this comment.
I would name this dimension Diagnosis instead of Diagnosis ID
There was a problem hiding this comment.
I see. We have " Diagnosis ID" in the customer DB. I guess it's named that way to stress that it contains diagnosis per patient (Ids) as opposed to actual diagnosis names.
My consideration here is to have a dimension name that contains space.
| @@ -0,0 +1,15 @@ | |||
| SUBDIRS := $(wildcard */.) | |||
There was a problem hiding this comment.
Odd choice to start using make scripts here again. Why would we choose make, and why is this part of transmart-data?
There was a problem hiding this comment.
Make scripts do not bring much here indeed. bash would do as well.
The rest of the test studies that are used by automatic tests are part of transmart-data currently.
So you could create the test ready db with make postgres_test.
Please feel free to create a ticket for separating test data from transmart-data where would decide on a new approach.
transmart-data/test_studies/Makefile
Outdated
|
|
||
| load: $(SUBDIRS) | ||
| $(SUBDIRS): $(TRANSMART_COPY) | ||
| @echo "Laading test study from $@ folder." |
There was a problem hiding this comment.
Typo (Laading -> Loading)
|
|
||
| TRANSMART_COPY_VERSION := 17.1-HYVE-5.7 | ||
| TRANSMART_COPY := transmart-copy-$(TRANSMART_COPY_VERSION).jar | ||
| TRANSMART_COPY_SRC_URL := https://repo.thehyve.nl/content/repositories/releases/org/transmartproject/transmart-copy/$(TRANSMART_COPY_VERSION)/transmart-copy-$(TRANSMART_COPY_VERSION).jar |
There was a problem hiding this comment.
Well, the source is located at ../../transmart-copy...
There was a problem hiding this comment.
true, but we release transmart-data as a separate component as well.
In dev setup, you could always build transmart-copy from sources and copy to the folder. make load won't fetch remote one if the version is right (TRANSMART_COPY_VERSION )
No description provided.