fix generator to be consistent with current plugin system #2
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
| @@ -16,7 +16,7 @@ export function doStartThings() { | |||
| ); | |||
| } | |||
|
|
|||
| export function doStopThings(api: typeof theia) { | |||
| export function stop(api: typeof theia) { | |||
There was a problem hiding this comment.
I think we are not sending as well theia object on stop (I forget to remove it)
it can be fixed later as well
|
do we need CI on this project as well ? |
|
I think, yes |
src/app/index.ts
Outdated
| @@ -93,6 +100,15 @@ module.exports = class TheiaPlugin extends Base { | |||
| (this.options as any).pluginName = answers.name | |||
| } | |||
|
|
|||
| if (!(this.options as any).publisher) { | |||
There was a problem hiding this comment.
what happens if here is no publisher ? (for example I only want to create a plugin locally) ? is there a default publisher value for that case ?
There was a problem hiding this comment.
You can omit publisher ID and it will equal an empty string.
There was a problem hiding this comment.
should publisher be then only a "parameter" of the generator (and not a question to user) ?
(like for theia extension where you can specify license, etc) so we don't ask the publisher information at first
it makes the flow to create the plugin as fast as possible.
We can check that publisher is valid only when we want to publish the extension
There was a problem hiding this comment.
For now, it is better to have a parameter.
And later it would be stored and read from .*rc file as default value.
There was a problem hiding this comment.
ok so we remove the question but we let "-p" option to give publisher and later we'll implement *.rcstuff ?
There was a problem hiding this comment.
yes,
I will add a fix
This PR updates the plugin generator to be consistent to theia-demo-plugins/wiptheia#1
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com