This repository has been archived by the owner on Jun 20, 2018. It is now read-only.
UI for manage Theia development mode #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliy-guliy
requested review from
benoitf,
evidolob,
ashumilova,
olexii4,
AndrienkoAleksandr,
mmorhun and
akurinnoy
|
are the changes for core packages proposed upstream ? |
benoitf
reviewed
May 14, 2018
| * Adds 'Development Host' status bar element and appends the same prefix to window title. | ||
| */ | ||
| @injectable() | ||
| export class HostedPluginInformer { |
There was a problem hiding this comment.
this class should implement FrontendApplicationContribution
and registered through
bind(FrontendApplicationContribution).to(HostedPluginInformer).inSingletonScope();
| } |
There was a problem hiding this comment.
I just added new empty line to the end
| @@ -87,6 +80,7 @@ export class StatusBarImpl extends VirtualWidget implements StatusBar { | |||
|
|
|||
| async setElement(id: string, entry: StatusBarEntry): Promise<void> { | |||
| await this.ready; | |||
| (entry as any).elementId = id; | |||
There was a problem hiding this comment.
Can we apply elementId to the StatusBarEntry interface to prevent such casting: (entry as any)?
There was a problem hiding this comment.
It has been already reworked
23 tasks
|
PR to upstream containing proposals to core package merged! |
AndrienkoAleksandr
approved these changes
Jun 5, 2018
benoitf
approved these changes
Jun 5, 2018
ashumilova
reviewed
Jun 5, 2018
| import { StatusBarAlignment, StatusBarEntry, FrontendApplicationContribution } from '@theia/core/lib/browser'; | ||
| import { HostedPluginServer } from '../../common/plugin-protocol'; | ||
| import { HostedPluginManagerClient, HostedPluginState, HostedPluginCommands } from './plugin-manager-client'; | ||
| import { CommandRegistry } from "@phosphor/commands"; |
| if (!pluginMetadata) { | ||
| this.frontendApplicationStateService.reachedState('ready').then(() => { | ||
| this.hostedPluginManagerClient.onStateChanged(e => { | ||
| if (e === 'starting') { |
mmorhun
approved these changes
Jun 6, 2018
akurinnoy
approved these changes
Jun 6, 2018
olexii4
approved these changes
Jun 6, 2018
| | 'running' | ||
| | 'stopping' | ||
| | 'failed'; | ||
|
|
There was a problem hiding this comment.
It will be better to use :
export enum HostedPluginState {
Stopped = 'stopped',
Starting = 'starting',
Running = 'running',
Stopping= 'stopping',
Failed = 'failed'
}
ashumilova
approved these changes
Jun 6, 2018
benoitf
pushed a commit
that referenced
this pull request
Jun 13, 2018
* UI for development mode * Code improvements
benoitf
pushed a commit
that referenced
this pull request
Jun 18, 2018
* UI for development mode * Code improvements
benoitf
pushed a commit
that referenced
this pull request
Jun 18, 2018
* UI for development mode * Code improvements
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
* UI for development mode * Code improvements
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
* UI for development mode * Code improvements Signed-off-by: Vitaliy Gulyy <vguliy@codenvy.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a status bar element displaying the state of Theia instance with hosted plugin.
Adds a status bar element notifying that Theia is running in dev mode with hosted plugin.
Issues to be resolved
Add info about Dev mode instance to the main Theia one eclipse-che/che#9402
Add UI to differ developer mode in Theia eclipse-che/che#9214