This repository has been archived by the owner on Jun 20, 2018. It is now read-only.
Add support for vscode:extension/ resolver and http(s):// resolver #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
approved these changes
May 17, 2018
mmorhun
approved these changes
May 17, 2018
|
|
||
| export default new ContainerModule(bind => { | ||
| bind(PluginDeployerFileHandler).to(PluginVsCodeFileHandler).inSingletonScope(); | ||
| bind(PluginDeployerDirectoryHandler).to(PluginVsCodeDirectoryHandler).inSingletonScope(); | ||
| bind(PluginScanner).to(VsCodePluginScanner).inSingletonScope(); | ||
| bind(PluginDeployerResolver).to(VsCodePluginDeployerResolver).inSingletonScope(); | ||
|
|
| console.log('filename is', filename); | ||
| console.log('dirname is', dirname); | ||
| /* | ||
| let filename = parsed.pathname pluginResolverContext.getOriginId().replace(/\W/g, '_'); |
There was a problem hiding this comment.
Is it needed? If so, format it properly, please.
There was a problem hiding this comment.
good catch :-) it shouldn't have reached the PR
olexii4
approved these changes
May 17, 2018
|
Impressive ! |
benoitf
added a commit
that referenced
this pull request
May 29, 2018
* Add support for vscode:extension/ resolver and http(s):// resolver
benoitf
added a commit
that referenced
this pull request
Jun 4, 2018
* Add support for vscode:extension/ resolver and http(s):// resolver
benoitf
added a commit
that referenced
this pull request
Jun 13, 2018
* Add support for vscode:extension/ resolver and http(s):// resolver
benoitf
added a commit
that referenced
this pull request
Jun 18, 2018
* Add support for vscode:extension/ resolver and http(s):// resolver
benoitf
added a commit
that referenced
this pull request
Jun 18, 2018
* Add support for vscode:extension/ resolver and http(s):// resolver
benoitf
added a commit
that referenced
this pull request
Jun 19, 2018
* Add support for vscode:extension/ resolver and http(s):// resolver
benoitf
added a commit
that referenced
this pull request
Jun 19, 2018
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to grab some vscode extension or download files hosted on a http(s) server