This repository has been archived by the owner on Jun 20, 2018. It is now read-only.
Add editor life cycle methods: open, save and close #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
benoitf
approved these changes
Jun 18, 2018
benoitf
reviewed
Jun 18, 2018
|
|
||
| // some well known URI schemas | ||
| export namespace Schemes { | ||
| export const file = 'file'; |
There was a problem hiding this comment.
I haven't find any code style rules about constants, so yes I rename it to File
There was a problem hiding this comment.
ok I thought FILE was for a constant, File a variable
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 18, 2018
eclipse-che/che#9435 add editor life cycle methods: open, save and close Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
eclipse-che/che#9435 add editor life cycle methods: open, save and close Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
eclipse-che/che#9435 add editor life cycle methods: open, save and close Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main issue eclipse-che/che#9435, also should cover eclipse-che/che#9906 and eclipse-che/che#9907
Signed-off-by: Yevhen Vydolob yvydolob@redhat.com