Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plug-in]Support VS Code XML Tooling #3317

Closed
apupier opened this issue Oct 30, 2018 · 4 comments
Closed

[plug-in]Support VS Code XML Tooling #3317

apupier opened this issue Oct 30, 2018 · 4 comments
Assignees

Comments

@apupier
Copy link
Contributor

apupier commented Oct 30, 2018

currently it is failing with:

root ERROR [hosted-plugin: 211] (node:211) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)
    at getSettings (/tmp/vscode-unpacked/vscode_extension_redhat_vscode_xml.vsix/extension/out/src/extension.js:74:29)
    at requirements.resolveRequirements.catch.then.requirements (/tmp/vscode-unpacked/vscode_extension_redhat_vscode_xml.vsix/extension/out/src/extension.js:45:48)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

the corresponding code is:

function getSettings() {
        let configXML = vscode_1.workspace.getConfiguration();
        configXML = configXML.get('xml');
        let x = JSON.stringify(configXML);
        let settings = JSON.parse(x);
        settings['logs']['file'] = logfile;
        return settings;
    }

Line 74 is the JSON.parse

@apupier
Copy link
Contributor Author

apupier commented Oct 30, 2018

//cc @benoitf

@apupier apupier changed the title [plugin]Support VS Code XML Tooling [plug-in]Support VS Code XML Tooling Oct 30, 2018
@benoitf benoitf self-assigned this Nov 2, 2018
@slemeur slemeur mentioned this issue Dec 11, 2018
69 tasks
@apupier
Copy link
Contributor Author

apupier commented Jan 29, 2019

seems that it is now another error: eclipse-che/che#12536

@vrubezhny
Copy link
Contributor

vrubezhny commented Feb 8, 2019

seems that it is now another error: eclipse/che#12536

This error is going to be addressed in #3540, I've tested the fix referenced from #3540 549668d and it looks like it does the thing: I was able to deploy vscode:extension/redhat.vscode-xml with no TypeError: Cannot read property 'editor.autoClosingBrackets' of undefined error appeared. However there is no PR made yet for #3540 - it is still in progress.

UPD: There is a PR created for #3540: #4296

@vrubezhny
Copy link
Contributor

After the PR for #3540 is merged, VSCode XML extension plug-in can be successfully deployed into theia and works fine.
I believe we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants