Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5656: Fixed the position of the button on Notification when displaying multiple lines of text #5657

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

BroKun
Copy link
Member

@BroKun BroKun commented Jul 8, 2019

This is a long-standing problem, it seems that removing the useless style settings is fine.

Signed-off-by: Brokun brokun0128@gmail.com

@akosyakov akosyakov added the notifications issues related to notifications label Jul 8, 2019
@BroKun
Copy link
Member Author

BroKun commented Jul 8, 2019

Sorry, there are some automatic formatting in it, I will deal with it.

@BroKun BroKun force-pushed the GH-5656 branch 2 times, most recently from 6c1aa86 to 36d1c6a Compare July 8, 2019 07:45
@BroKun
Copy link
Member Author

BroKun commented Jul 8, 2019

Sorry, there are some automatic formatting in it, I will deal with it.

It’s clean now @akosyakov @AlexTugarev

@vince-fugnitto
Copy link
Member

It works fine for me, I tested a message with multiple lines :)
Do you think the commit message should be updated, I don't believe it addresses button performance.

…ion when displaying multiple lines of text

Signed-off-by: Brokun <brokun0128@gmail.com>
@BroKun BroKun changed the title fix #5656: Improved button performance when displaying multiple lines… fix #5656: Fixed the position of the button on Notification when displaying multiple lines of text Jul 8, 2019
@BroKun
Copy link
Member Author

BroKun commented Jul 8, 2019

It works fine for me, I tested a message with multiple lines :)
Do you think the commit message should be updated, I don't believe it addresses button performance.

Forgive me for my poor English.

@vince-fugnitto
Copy link
Member

It works fine for me, I tested a message with multiple lines :)
Do you think the commit message should be updated, I don't believe it addresses button performance.

Forgive me for my poor English.

No that's alright, don't worry! :)

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jul 8, 2019

The PR is fine for the moment, but I still think we should try and update our notifications (or messages) similarly to vscode. They're easier to read, take up less space and look nicer in general.

image

However there is another issue for that (#1360) and it's not necessary it'd be part of this PR.

Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! Thanks a lot!

@AlexTugarev AlexTugarev merged commit b0a2d87 into eclipse-theia:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notifications issues related to notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants