-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #5656: Fixed the position of the button on Notification when displaying multiple lines of text #5657
Conversation
Sorry, there are some automatic formatting in it, I will deal with it. |
6c1aa86
to
36d1c6a
Compare
It’s clean now @akosyakov @AlexTugarev |
It works fine for me, I tested a message with multiple lines :) |
…ion when displaying multiple lines of text Signed-off-by: Brokun <brokun0128@gmail.com>
Forgive me for my poor English. |
No that's alright, don't worry! :) |
The PR is fine for the moment, but I still think we should try and update our notifications (or messages) similarly to vscode. They're easier to read, take up less space and look nicer in general. However there is another issue for that (#1360) and it's not necessary it'd be part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely! Thanks a lot!
This is a long-standing problem, it seems that removing the useless style settings is fine.
Signed-off-by: Brokun brokun0128@gmail.com