Make the Plugin folder notification user friendly
#5731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattarajoy
force-pushed
the
fixPluginFolderUri
branch
from
2ae922c to
e0e04a3
Compare
|
Thank you for the PR. We should use |
kittaakos
reviewed
Jul 17, 2019
| @@ -265,7 +265,7 @@ export class HostedPluginManagerClient { | |||
| if (UriSelection.is(result)) { | |||
| if (await this.hostedPluginServer.isPluginValid(result.uri.toString())) { | |||
| this.pluginLocation = result.uri; | |||
| this.messageService.info('Plugin folder is set to: ' + result.uri.toString()); | |||
| this.messageService.info('Plugin folder is set to: ' + decodeURI(result.uri.toString())); | |||
There was a problem hiding this comment.
You can use result.uri.toString(true) instead.
There was a problem hiding this comment.
thinking again, LabelProvider.getLongName should be used to a display string from a URI to align with the rest of UI
chattarajoy
force-pushed
the
fixPluginFolderUri
branch
from
491783a to
dc78218
Compare
|
@chattarajoy, please squash your commits. |
Signed-off-by: Joy Lal Chattaraj <Joylal4896@gmail.com>
chattarajoy
force-pushed
the
fixPluginFolderUri
branch
from
dc78218 to
f47c6c1
Compare
|
@kittaakos, have squashed the commits |
I am trying this now on Windows. |
|
It looks better now on Windows. Thank you for the help, @chattarajoy!
|
kittaakos
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5693.
The message displayed contained an encoded URI, added changes to decode it before displaying the message.