-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix execution of configured tasks #5772
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@evidolob @vince-fugnitto @elaihau |
@vince-fugnitto Why @elaihau cannot review it? |
He of course can, I was just thinking it wasn't necessary since he's currently at a limited capacity and the feature is |
Super confusing, @RomanNikitenko how are you going to consume these changes? Why don't you rebind these services in Che Theia and customize as other clients do? |
@akosyakov thank you for your advice and your wish to help! |
@RomanNikitenko Do you mean that we should do 0.8.1 bug fix release? @elaihau yes? If not what we supposed to do with this branch? If you need to fix something for Che, then we have DI that one can subclass and overwrite bogus classes, and then rollback it after going to 0.9. |
We don't need to have release(at least for now), we build Theia from sources. |
@evidolob please announce it on spectrum and join dev meeting to discuss it today |
I've updated an agenda: https://github.com/theia-ide/theia/wiki/Dev-Meetings#agenda-2019-07-23 |
What does this PR do?
Fix execution of configured tasks
What issues does this PR fix or reference?
How to test
Use the components in your devfile
Try to configure some
detected
task and then run it. Also you can try to run the task after refreshing page fromrecently used
sectionNote: you can not see output for tasks provided by plugins, because of eclipse-che/che#13876, but you can see events that task has started or completed.
Please see the video:https://youtu.be/3KB1GvwXH_M
Signed-off-by: Roman Nikitenko rnikiten@redhat.com