Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution of configured tasks #5772

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Jul 22, 2019

What does this PR do?

Fix execution of configured tasks

What issues does this PR fix or reference?

How to test

Use the components in your devfile

- 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/RomanNikitenko/che-plugin-registry/master/v3/plugins/eclipse/che-theia/custom/meta.yaml
    type: cheEditor
  
  - 
    id: che-incubator/typescript/1.30.2
    type: chePlugin
    memoryLimit: 2048M

Try to configure some detected task and then run it. Also you can try to run the task after refreshing page from recently used section
Note: you can not see output for tasks provided by plugins, because of eclipse-che/che#13876, but you can see events that task has started or completed.

Please see the video:https://youtu.be/3KB1GvwXH_M

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
Copy link
Contributor Author

@evidolob @vince-fugnitto @elaihau
This is PR for che-7.0.0 branch, not for master branch.

@vince-fugnitto vince-fugnitto removed the request for review from elaihau July 22, 2019 14:53
@akosyakov
Copy link
Member

@vince-fugnitto Why @elaihau cannot review it?

@akosyakov akosyakov added the tasks issues related to the task system label Jul 22, 2019
@vince-fugnitto
Copy link
Member

@vince-fugnitto Why @elaihau cannot review it?

He of course can, I was just thinking it wasn't necessary since he's currently at a limited capacity and the feature is che specific (che branch).

@akosyakov
Copy link
Member

akosyakov commented Jul 22, 2019

Super confusing, @RomanNikitenko how are you going to consume these changes? Why don't you rebind these services in Che Theia and customize as other clients do?

@RomanNikitenko
Copy link
Contributor Author

RomanNikitenko commented Jul 22, 2019

@akosyakov
I don't need to customize something here. I'm just trying to fix the bugs defined in the PR description for 0.8.0 version. For master branch it's not relevant because the behavior for detected tasks was changed.
I described it here.

thank you for your advice and your wish to help!

@akosyakov
Copy link
Member

@RomanNikitenko Do you mean that we should do 0.8.1 bug fix release? @elaihau yes? If not what we supposed to do with this branch? If you need to fix something for Che, then we have DI that one can subclass and overwrite bogus classes, and then rollback it after going to 0.9.

@evidolob
Copy link
Contributor

We don't need to have release(at least for now), we build Theia from sources.
I write an email for theia-dev eclipse mailing list that we will use that branch for Che 7 release.
I will delete this che-7.0.0 branch in next few mounts, but first I will ask to create tag from that branch.
It looks like this PR will be only one fix which doesn't exist in master branch.

@RomanNikitenko RomanNikitenko merged commit 7f21080 into che-7.0.0 Jul 23, 2019
@RomanNikitenko RomanNikitenko deleted the fix_configured_task_execution branch July 23, 2019 09:21
@akosyakov
Copy link
Member

@evidolob please announce it on spectrum and join dev meeting to discuss it today

@akosyakov
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants