Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal widget is not displayed for theia tasks #13876

Closed
5 of 23 tasks
RomanNikitenko opened this issue Jul 17, 2019 · 2 comments
Closed
5 of 23 tasks

Terminal widget is not displayed for theia tasks #13876

RomanNikitenko opened this issue Jul 17, 2019 · 2 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone

Comments

@RomanNikitenko
Copy link
Member

Describe the bug

Terminal widget works well for che tasks, but it is not displayed for theia tasks, so user can not see output for tasks with shell type, for example.

Che version

  • latest
  • nightly
  • other: 7.0.0-rc-4.0-SNAPSHOT

Steps to reproduce

  1. Create workspace using any stack from dashboard
  2. Create tasks.json file in /projects/.theia directory
  3. Add the content:
{
    "tasks": [
        {
            "label": "Run my test task",
            "type": "shell",
            "command": "./task-long-running"
        }
    ]
}
  1. Create file task-long-running in /projects directory with content:
#!/bin/bash

for i in {1..5}
do
   sleep 1
   echo "tasking... $i"
done

  1. Go to the terminal: chmod +x task-long-running
  2. Go to Terminal => Run Task and run the task
  3. You can see:
  • message that task has been started
  • the process is running (from terminal)
  • in 5 sec message that task has exited
  • but output is absent - terminal widget is not displayed
  • error in browser console at creating terminal widget

Please see the video: https://youtu.be/hPgVKivYsoo

Expected behavior

Please see the video how it works for theia project: https://youtu.be/GiwqXal3Knc

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (minikube v1.0.0 on linux (amd64))
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

terminal_widget_error

Installation method

  • chectl (chectl/0.0.2-6d3894f linux-x64 node-v10.4.1)
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 17, 2019
@slemeur slemeur added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. area/editor/theia Issues related to the che-theia IDE of Che labels Jul 17, 2019
@slemeur slemeur added this to the 7.0.0 milestone Jul 17, 2019
@l0rd l0rd mentioned this issue Jul 17, 2019
85 tasks
@evidolob evidolob self-assigned this Jul 18, 2019
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Jul 22, 2019
@AndrienkoAleksandr AndrienkoAleksandr added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 22, 2019
@vparfonov vparfonov removed their assignment Jul 22, 2019
@AndrienkoAleksandr AndrienkoAleksandr added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jul 23, 2019
@vparfonov vparfonov reopened this Jul 23, 2019
@vparfonov
Copy link
Contributor

Will we cherry-pick eclipse-che/che-theia#365 to the 7.0.0 branch ?

@l0rd l0rd added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 23, 2019
@evidolob
Copy link
Contributor

Yes eclipse-che/che-theia#368

@AndrienkoAleksandr AndrienkoAleksandr removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. status/in-progress This issue has been taken by an engineer and is under active development. labels Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

No branches or pull requests

6 participants