Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing registration for git preferences provisioner #14488

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Add missing registration for git preferences provisioner #14488

merged 1 commit into from
Sep 10, 2019

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Sep 9, 2019

What does this PR do?

Add missing registration in OpenShift instrastructure for the git preferences provisioner.

Signed-off-by: Vlad Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

#13876

Release Notes

N/A

Docs PR

N/A

@vzhukovs
Add missing registration for git preferences provisioner
4bd8dae 
Signed-off-by: Vlad Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Sep 9, 2019
@vzhukovs vzhukovs added this to the 7.2.0 milestone Sep 9, 2019
@vzhukovs vzhukovs requested a review from metlos September 9, 2019 13:05
@vzhukovs vzhukovs self-assigned this Sep 9, 2019
@vzhukovs vzhukovs mentioned this pull request Sep 9, 2019
Merged
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 9, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 9, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

amisevsk
amisevsk requested changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR should not be merged before #14442 or it will introduce #14436 on OpenShift.

@che-bot
Copy link
Contributor

che-bot commented Sep 9, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@vzhukovs
Copy link
Contributor Author

@amisevsk this PR is ready to merge. #14442 has been already merged into master.

amisevsk
amisevsk approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vzhukovskii

@vzhukovs vzhukovs merged commit df3874d into master Sep 10, 2019
@vzhukovs vzhukovs deleted the che#13876-missing-registration branch September 10, 2019 14:47
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@metlos metlos metlos approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@vzhukovs vzhukovs

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vzhukovs @che-bot @metlos @sleshchenko @amisevsk