Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

CHE-13876: Fix displaying theia tasks output. #365

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

  • Fix displaying theia tasks output;
  • Don't use in the code concrete remote terminal implementation, use interface.

Manually tested:

  • Che-theia tasks - works;
  • Che-theia terminal - works;
  • Che-theia terminal plugin api - works;
  • Theia tasks - works;

What issues does this PR fix or reference?

eclipse-che/che#13876

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@musienko-maxim
Copy link

Can one of the admins verify this PR?

@evidolob evidolob added this to the 7.0.0 milestone Jul 23, 2019
@benoitf
Copy link
Contributor

benoitf commented Jul 23, 2019

@AndrienkoAleksandr as milestone is for 7.0.0 it needs to be in 7.0.0 branch as well

@AndrienkoAleksandr AndrienkoAleksandr merged commit 29815f7 into master Jul 23, 2019
@AndrienkoAleksandr AndrienkoAleksandr deleted the CHE-13876 branch July 23, 2019 13:18
AndrienkoAleksandr added a commit that referenced this pull request Jul 23, 2019
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr added a commit that referenced this pull request Jul 23, 2019
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr added a commit that referenced this pull request Jul 24, 2019
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants