Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cpp grammars to textmate-grammars extension #5803

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Move cpp grammars to textmate-grammars extension #5803

merged 1 commit into from
Jul 26, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 26, 2019

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What does this issue do

Moves C/C++ grammrars to @theia/textmate-grammars extension.

Reference issue

#5798

How to test

Start Theia and see that @thiea/cpp extension works well

@tolusha tolusha requested a review from akosyakov July 26, 2019 01:47
@tolusha tolusha self-assigned this Jul 26, 2019
@tolusha tolusha added cpp issues related to the C/C++ language enhancement issues that are enhancements to current functionality - nice to haves labels Jul 26, 2019
@slemeur slemeur mentioned this pull request Jul 26, 2019
Closed
20 tasks
akosyakov
akosyakov approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested both native and vscode extensions independently. They still seem to work, i.e. LS is started.

@tolusha
Move cpp grammars to @theia/textmate-grammars extension
5f0c0c6 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha merged commit f5161db into master Jul 26, 2019
@tolusha tolusha deleted the ab/cppgrammars branch July 26, 2019 09:33
@vince-fugnitto vince-fugnitto mentioned this pull request Aug 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

@marcdumais-work marcdumais-work Awaiting requested review from marcdumais-work

@paul-marechal paul-marechal Awaiting requested review from paul-marechal

@simark simark Awaiting requested review from simark

Assignees

@tolusha tolusha

Labels
cpp issues related to the C/C++ language enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tolusha @akosyakov