-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git Init in current Workspace #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jbicker please follow PR template: https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#opening-a-pull-request |
akosyakov
reviewed
Aug 21, 2019
akosyakov
reviewed
Aug 21, 2019
jbicker
force-pushed
the
git-init
branch
2 times, most recently
from
August 21, 2019 15:53
16cc64e
to
c4d924b
Compare
kittaakos
reviewed
Aug 21, 2019
akosyakov
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested that:
- scm toolbar items are available as before if a folder already contains a git repository;
- only init repository is available if there is no git repository;
- and that init repository command works properly.
Everything went alright for me, thank you!
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #5936
The current Workspace can be initialized as a Git Repository now.
How to test
Create a new Workspace and open it in theia.
Open the git view. You should see the note that there is no repository yet.
Hit the plus in the Git View Header.
Now you should see the Git View with the respective commit message field and so on.
Review checklist
Reminder for reviewers