Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreExecutor on IE9 accesses console in unsafe way #597

Closed
kitsonk opened this issue Mar 28, 2016 · 4 comments
Closed

PreExecutor on IE9 accesses console in unsafe way #597

kitsonk opened this issue Mar 28, 2016 · 4 comments
Labels
bug Something that's not working as intended

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Mar 28, 2016

On several lines, the PreExecutor tries to log to console. console is not available in IE9 when the debug window is not open, which is causing the PreExecutor to fail on most on demand platforms (which don't have the console open).

I thought we had a way for dealing with messages without writing to console, by interfacing with the reporter.

@kitsonk kitsonk added the bug Something that's not working as intended label Mar 28, 2016
@jason0x43
Copy link
Member

Gah, I need to modify the self tests to actually exercise Intern itself as part of the testing process (and remember that we're still supporting IE9).

@jason0x43
Copy link
Member

Regarding reporters, the issue is that the reporters haven't loaded at the point suite resolution happens. A better solution would be for the client to only attempt resolution if it was required; then if it fails, the client can throw an error. The tricky part there is how to definitively check for globs in the suites list.

@jason0x43
Copy link
Member

I'm working on some improvements in the browser-glob branch. A mid filter is now run before trying to resolve, both in node and the browser. This prevents certain constructs, like 'dojo/has!host-node?fs', from being interpreted as globs, and allows the browser client to skip resolution if nothing needs resolving. Intern will no longer attempt to resolve MIDs involving browser plugins. Resolution failures now show up as session errors, so they're much more visible. IE9 still can't resolve suites, but it now works when none of the suites actually involve glob expressions.

@jason0x43
Copy link
Member

Fixed in 7dc526a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants