-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executor on IE9 accesses console in unsafe way #818
Comments
Intern 4 doesn't currently support IE 9 and hasn't been tested with it. Aside from the console issue, there's an arrow function in the browser client, and it looks like the xhr module from @dojo/core/request may have some issues with IE 9 as well. That's not to say we can't improve IE 9 functionality but it will likely involve some upstream changes as well as updates to Intern itself. |
Now that I think about it, I'm kind of surprised that arrow function hasn't been more of a problem... |
Got it, yeah I noticed that arrow function too! Might be worth mentioning explicitly in the docs? The main line from the README is "Intern can run unit tests in browsers that support ECMAScript 5" - it sounds like that's not entirely accurate for Intern 4. |
True. I'll mention the lack of IE9 support. |
- Use a console module for console access to handle the case where the global console isn't defined - Remove an arrow function from the browser client references #818
Expected behavior
There are some calls to
console
methods that don't exist in IE9 in the Executor.ts file that seem to break tests on IE9 when running via the Remote Suite.It looks like this was resolved in PreExecutor in this bug but then I think the
console
calls were added to Executor a few months later?I think there are two
console.warn
calls because of theserverUrl
andsocketPort
params added to the test harness page in RemoteSuite. When I go to the test harness page in a modern browser, I see:But in IE9 it logs
Current behavior
IE9 returns an error due to console not existing and the remote suite times out.
Possible solution
Steps to reproduce (for bugs)
Environment
Intern version: 4.0.1
Node version: 7.1.0
NPM version: 3.10.9
Browser version: IE9
Additional information
The text was updated successfully, but these errors were encountered: