unit test keep-alive implementation, refs #49 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // issue a keep-alive heartbeat to ensure that Sauce Labs knows the session is still active.For more info | ||
| // on Sauce timeouts, see https://saucelabs.com/docs/additional-config. | ||
| heartbeat = setInterval(function () { | ||
| remote._wd.url(); |
There was a problem hiding this comment.
don’t access privates of other objects. create a new method on PromisedWebDriver like setHeartbeatInterval that does this, and call it here.
|
refs #49 |
| @@ -49,11 +49,20 @@ define([ | |||
| topic.subscribe('/client/end', function (sessionId) { | |||
| if (sessionId === remote.sessionId) { | |||
| clearHandles(); | |||
| // Passing a delay of 0 clears the current interval and won't create a new one | |||
There was a problem hiding this comment.
if you are going to add a comment, please use it to explain why not what. (I personally do not think a comment is actually needed here.)
|
Reimplemented based on this in 02ff6d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intern runs unit tests on the remote Selenium server by navigating to the client runner HTML page. No Selenium commands are issued after this initial call to remote.get() below, so Sauce Labs will assume failure if unit tests take longer than the specified "idle-timeout" Sauce capabilities parameter.
This PR takes care of issuing a keep-alive heartbeat to ensure that Sauce Labs knows the session is still active.
For more info on Sauce timeouts, see https://saucelabs.com/docs/additional-config.