Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cucumber #650

Closed
wants to merge 13 commits into from
Closed

Integrate cucumber #650

wants to merge 13 commits into from

Conversation

rhpijnacker
Copy link
Contributor

@rhpijnacker rhpijnacker commented Jul 14, 2016

This PR integrates the Cucumber.js test runner into Intern to allow tests to be written in Gherkin syntax. See #81 and PR #196.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@morrinene morrinene added this to the 4.0 milestone Oct 12, 2016
@jason0x43 jason0x43 force-pushed the master branch 4 times, most recently from db94ff3 to 215dcbd Compare November 18, 2016 13:52
@jason0x43 jason0x43 force-pushed the master branch 12 times, most recently from 2eedd67 to 39fd4bf Compare November 18, 2016 14:05
@jsf-clabot
Copy link

jsf-clabot commented Dec 9, 2016

CLA assistant check
All committers have signed the CLA.

@rhpijnacker
Copy link
Contributor Author

It is about half a year since this pull-request was posted. Any ideas on whether this will ever be integrated?

@dylans
Copy link

dylans commented Jan 16, 2017

@rhpijnacker I think we got to the point of debating whether Intern should be able to call out to Cucumber (which is what your PR does), or if Intern should natively support Cucumber syntax so that it could do more with that.

I think we can reasonably make a persuasive argument for both approaches, but given that this is what we have, we should consider landing it for say a 3.5 before we finish the TS refactor for Intern 4? Or perhaps its better to have this as a separate package (e.g. intern-cucumber) since this does introduce a dependency on Cucumber for all Intern users, whether the use Cucumber or not?

Either way, let's make a decision. :)

@jason0x43
Copy link
Member

I think ideally the cucumber interface should just be an interface that constructs regular Intern Suites rather than relying on Cucumber to run tests. Aside from being lighter weight, this would ensure that Cucumber tests are handled the same as other tests within Intern. The gherkin parser used by cucumber is a standalone project with no other dependencies; we should see what would be involved in using it.

@rhpijnacker
Copy link
Contributor Author

@dylans Putting this in a separate package seems to make sense. However, I could use some assistance on how to set this up, both package-structure wise (how do we get intern to know about the additional package) and location/publication wise (is just having another github repo enough?)

@dylans
Copy link

dylans commented Jan 18, 2017

@rhpijnacker I was thinking something along the lines of https://github.com/theintern/intern-visual or https://github.com/theintern/intern-a11y in terms of how they extend Intern, though admittedly I've not thought through the details enough to know if that would work well or not.

I know we do want to eventually do what @jason0x43 suggested in the previous comment, "ideally the cucumber interface should just be an interface that constructs regular Intern Suites rather than relying on Cucumber to run tests.", though I appreciate what you have now is a workable solution (and why I think it probably makes more sense as an extension in its current form if possible).

@jason0x43 jason0x43 removed this from the Intern 4.0 milestone Aug 7, 2017
@rhpijnacker
Copy link
Contributor Author

This pull-request was superceded by https://github.com/rhpijnacker/intern-cucumber/.
So, I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants