Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass reporter options to istanbul reporters #815

Closed
wants to merge 4 commits into from

Conversation

bryanforbes
Copy link
Member

Fixes #814

* Move Coverage to BaseCoverage
* Create new Coverage that inherits from BaseCoverage
* Ensure other coverage reporters pass the right options to istanbul

Fixes theintern#814
@bryanforbes bryanforbes requested a review from jason0x43 October 11, 2017 18:44
@codecov-io
Copy link

codecov-io commented Oct 11, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@44fcdfd). Click here to learn what that means.
The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #815   +/-   ##
=========================================
  Coverage          ?   93.07%           
=========================================
  Files             ?       55           
  Lines             ?     4393           
  Branches          ?      955           
=========================================
  Hits              ?     4089           
  Misses            ?      304           
  Partials          ?        0
Impacted Files Coverage Δ
src/lib/reporters/Pretty.ts 91.11% <100%> (ø)
src/lib/reporters/Cobertura.ts 100% <100%> (ø)
src/lib/reporters/TextCoverage.ts 100% <100%> (ø)
src/lib/reporters/Simple.ts 100% <100%> (ø)
src/lib/reporters/HtmlCoverage.ts 100% <100%> (ø)
src/lib/reporters/Runner.ts 98.89% <100%> (ø)
src/lib/reporters/Coverage.ts 96.96% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fcdfd...ee49a0b. Read the comment docs.

@jason0x43
Copy link
Member

Merged in 2ce94a2

@jason0x43 jason0x43 closed this Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants